feat: add custom branch actions (run, install, etc)#31
Merged
Conversation
Standardize error handling across internal crates to use anyhow::Result, while maintaining Result<T, String> at public API boundaries (Tauri commands). Add comprehensive safety documentation to unsafe libc::kill usage. Changes: - Convert acp-client to use anyhow::Result internally for better error context - Update acp_provider to leverage native anyhow::Result (remove redundant conversion) - Add detailed safety documentation to unsafe code in executor.rs explaining: - PID validity and ownership considerations - PID reuse risks and mitigations - Signal choice rationale (SIGTERM vs SIGKILL) - Error handling decisions - Update acp-client README with new error handling patterns This addresses code quality issues identified in code review, improving error ergonomics while maintaining clear API boundaries. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Remove dead code from RunningActionState struct in executor.rs. The execution_id, action_metadata, and started_at fields were stored but never read. Only child_pid and output_buffer are actually used by the stop() and get_buffered_output() methods. This change eliminates unnecessary data storage and removes the #[allow(dead_code)] attribute that was hiding the issue. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Move all action items (run, build, format, check, test, cleanUp, prerun) from the top-level "..." menu into an "Actions" submenu. This improves organization and reduces visual clutter in the branch card menu. Menu structure is now: - Actions (submenu containing all project actions) - Copy Worktree Path - Delete Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Changed submenu overflow from 'hidden' to 'overflow-y: auto' with a max-height of 400px to allow viewing all action items when the list exceeds the viewport height. Previously, only the shadow was visible when the submenu extended beyond the visible area. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Fixed an issue where nested submenus (e.g., Build actions within the Actions submenu) were not visible due to parent overflow clipping. The fix ensures that only the first-level Actions submenu scrolls, while nested submenus can overflow outside their parent container to remain fully visible. - Changed base .submenu from overflow-y: auto to no overflow - Added specific rule for first-level submenus to enable scrolling - Added rule for nested submenus to allow overflow: visible - Added flex layout to submenu containers for proper sizing Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Remove nested category-based submenus (Run, Build, Format, etc.) from the actions submenu to simplify the UI. All actions now display directly in a single flat list within the Actions submenu. Changes: - Remove conditional logic that created nested submenus for 3+ actions - Display all actions directly in the actions submenu - Remove expandedSubmenu state and related submenu handlers - Clean up CSS rules for nested submenus - Simplify menu interaction logic Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
wesbillman
previously approved these changes
Feb 11, 2026
Run cargo fmt to apply standard Rust formatting across all crates. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
wesbillman
approved these changes
Feb 11, 2026
loganj
added a commit
that referenced
this pull request
Feb 26, 2026
Fix runtime source detection and overlapping source de-dup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
builderbot-actionscrateChanges
Backend
builderbot-actionscrate with consolidatedActionTypeenumFrontend
Features