Fix spinner wobbling with centralized Spinner component#44
Merged
wesbillman merged 2 commits intomainfrom Feb 11, 2026
Merged
Conversation
Creates a centralized Spinner component that handles all spinner usage across the application. This component: - Supports all current sizes (12px, 14px, 16px, 20px, 24px) - Supports both Loader2 and RefreshCw icons - Fixes wobbling issues with proper CSS (transform-origin, will-change) - Uses Svelte 5 runes ($derived, $props) - Consolidates duplicate spinner CSS across 13 components All spinner instances have been migrated to use the new component, removing duplicate @Keyframes definitions and inconsistent styling. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Removes unused :global(.spinning) CSS rules from ActionOutputModal and NewSessionModal, plus the global .spinner/.spinning classes from app.css. The centralized Spinner component now handles all spinner styling and animation internally via its own .spinner class. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
0ad3e62 to
82a01fb
Compare
wesbillman
approved these changes
Feb 11, 2026
loganj
added a commit
that referenced
this pull request
Feb 26, 2026
## Summary - Add `transport_test.go` with end-to-end HTTP transport tests - Tests: find_project roundtrip, full thread lifecycle (create → list → reply → read), files_in_review **Stack**: Stacked on PR 3 (MCP tools). ## Test plan - [x] `go test ./internal/mcpserver/ -run TestMCPOverHTTP -v` — all 3 tests pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Spinner.sveltecomponent to fix wobbling issues across the applicationChanges
New Component
Spinner.svelte: Centralized component supporting all sizes (12px-24px) and both Loader2/RefreshCw iconstransform-originandwill-changeCSS$derived,$props)Refactored Components
Updated 13 components to use the new Spinner component:
Cleanup
@keyframes spindefinitions (13 instances).spinningCSS rules from ActionOutputModal and NewSessionModal.spinner/.spinningclasses from app.cssTest plan
🤖 Generated with Claude Code