fix: remove double confirmation dialog on remote branch deletion#46
Merged
fix: remove double confirmation dialog on remote branch deletion#46
Conversation
Remove the redundant confirmation dialog from RemoteBranchCard.svelte that was triggering before the parent ProjectHome.svelte confirmation. Remote branch deletion now follows the same pattern as local branches: the card calls onDelete() directly, and ProjectHome handles the single confirmation dialog. The ProjectHome confirmation is now branch-type-aware: - Local branches: mentions worktree deletion (cannot be undone) - Remote branches: mentions stopping the workspace (may be reused)
matt2e
approved these changes
Feb 11, 2026
loganj
added a commit
that referenced
this pull request
Feb 26, 2026
…st_infrastructure_and_smoke_tests test: add Playwright e2e test infrastructure and review workflow test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the redundant confirmation dialog from
RemoteBranchCard.sveltethat was triggering before the parentProjectHome.svelteconfirmation. Remote branch deletion now follows the same pattern as local branches: the card callsonDelete()directly, andProjectHomehandles the single confirmation dialog.Changes
RemoteBranchCard.svelte: Removed the inlineconfirmDeletedialog. The delete action now callsonDelete?.()directly, matching the local branch pattern.ProjectHome.svelte: Made the shared confirmation dialog branch-type-aware:Why
Previously, deleting a remote branch would show two confirmation dialogs in sequence — one from
RemoteBranchCardand another fromProjectHome. This was confusing and inconsistent with the local branch deletion flow, which only showed a single confirmation.