fix: run pre-run actions sequentially instead of simultaneously#82
Merged
fix: run pre-run actions sequentially instead of simultaneously#82
Conversation
The run_prerun_actions function was calling executor.execute() which spawns each action in a background thread and returns immediately. This caused all prerun actions to run simultaneously rather than sequentially. Changes: - Add tokio::sync::oneshot import to executor.rs - Refactor execute() into a private execute_inner() that returns both the execution ID and a oneshot::Receiver<()> for completion signaling - The background completion thread now sends on the oneshot channel when done - Add public execute_and_wait() method that awaits the completion signal - Keep existing execute() method unchanged (drops the receiver, fire-and-forget) - Update run_prerun_actions to use execute_and_wait so each action completes before the next one starts
wesbillman
approved these changes
Feb 12, 2026
loganj
added a commit
that referenced
this pull request
Feb 26, 2026
feat: native features (menu, window, title bar) Add native macOS experience with: - Overlay title bar with hidden title for clean appearance - Traffic light (close/minimize/maximize) positioning via tauri-plugin-decorum - Application menu: Penpal, Edit, View (reload, devtools, fullscreen), Window - Custom menu event handlers for reload and toggle devtools - Sidecar spawn: launches Go server on startup, waits for ready - Go template adjustments: data-tauri-drag-region on topbar, padding for traffic lights, Tauri detection via __TAURI__ global Co-Authored-By: Claude Opus 4.6 <[email protected]> feat: browser-style tabs, multi-window support, and app icons Add tab bar below topbar with cmd-click to open links in new tabs, middle-click to close tabs, and cmd+shift+click to open in new Tauri window. Add Liquid Glass macOS icon via compiled Assets.car with CFBundleIconName, favicon for browser mode, and updated all platform icon assets. Co-Authored-By: Claude Opus 4.6 <[email protected]> fix: eliminate tab title flicker when opening new tab Navigate directly to first workspace instead of going through / and waiting for async IndexRedirect, which caused a visible "Home" → workspace name flicker. Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the action executor to run pre-run actions sequentially, waiting for each to complete before starting the next one.
Changes:
execute_innerwhich returns aoneshot::Receiverfor completion signalingexecute_and_waitmethod that awaits the completion signal before returningrun_prerun_actionsto useexecute_and_waitso actions run one at a timeexecutemethod unchanged for fire-and-forget usage