Refactor the _setup_plots in BEC #1815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we'd need to drop Python 3.8 for this (?) If the numpy conventions are to be followed... then?
|
dd9e8ea to
530e66f
Compare
|
👍🏻 in principle, but |
|
"power cycled" to re-trigger CI and get new (synthentic) merge commit. |
tacaswell
approved these changes
Dec 23, 2024
|
I think something got stricter in the underyling typing (and maybe mpl 3.10) so that still needs some work, but 👍🏻 in principal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted some logic from _setup_plots into 3 helper functions