fix: integrate remaining installer hardening - #26
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4e39aaa7c6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ; This is the password that allows database operations: | ||
| admin_passwd = ${OE_SUPERADMIN} | ||
| ${ODOO_PORT_CONFIG} | ||
| db_name = ${ODOO_DATABASE_NAME} |
There was a problem hiding this comment.
Gate db_name on database initialization
When INITIALIZE_ODOO_DATABASE is set to False to keep the previous installer behavior, the generated config still pins Odoo to ODOO_DATABASE_NAME through db_name. That means installs that intentionally skip the new pre-created database can no longer use the database manager or an existing database with another name unless they also discover and override ODOO_DATABASE_NAME, so the opt-out does not fully disable the new database-selection behavior.
Useful? React with 👍 / 👎.
Summary
19.0branch after the stacked PRs were merged into intermediate bases/odoo/custom-addonsdefault19.0Root Cause
Only PR #18 was actually present on
19.0. PRs #19-#24 were merged into the stacked intermediate branches, so downloadinghttps://raw.githubusercontent.com/boGSer98/InstallScript/19.0/odoo_install.shstill missed the later hardening commits.Test Plan
python3 -m unittest tests/test_installer_features.py -vbash -n odoo_install.shscripts/validate.shgit diff --check