fix: make full apt upgrade opt-in - #27
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apt-get upgradeopt-in viaRUN_APT_UPGRADE="False"by defaultapt-get updateand dependency installs enabled, but skips upgrading all existing packages during unattended Odoo installationRoot Cause
The installer was still running a full
apt-get upgrade -yearly in the install. Even with non-interactive apt and bounded lock waits, a full OS package upgrade can spend a long time in dpkg package triggers such asman-db, which makes the installer look stuck atProcessing triggers for man-db ...on minimal/customer servers. The Odoo installer only needs to install its dependencies, not upgrade every already-installed package.Test Plan
python3 -m unittest tests.test_installer_features.InstallerFeatureTests.test_full_apt_upgrade_is_opt_in_to_avoid_man_db_trigger_hangs -vpython3 -m unittest tests/test_installer_features.py -vbash -n odoo_install.shscripts/validate.shgit diff --check