fix: remove general apt update and upgrade step - #28
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e380cd189d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| else | ||
| echo "Skipping full apt upgrade (RUN_APT_UPGRADE=False) to avoid long package triggers such as man-db." | ||
| fi | ||
| apt_get install -y libpq-dev |
There was a problem hiding this comment.
Refresh apt metadata before the first install
When the installer is run in the repo’s provided test_install Ubuntu image, test_install/Dockerfile removes /var/lib/apt/lists/* after bootstrapping the base tools, so this first apt_get install now runs with no package metadata and exits with “Unable to locate package” before the later PGDG-specific apt_get update is reached. This breaks the default Ubuntu install path in that documented test environment; keep a metadata refresh before the first package install while still omitting the full upgrade.
Useful? React with 👍 / 👎.
Summary
RUN_APT_UPGRADEinklusive Validierung und Doku.apt-get update/apt-get upgrade-Block auch aus dem Debian-Installer.Test Plan
bash -n odoo_install.shbash -n odoo_install_debian.shpython3 -m unittest tests/test_installer_features.py-> 23 Tests OKHinweis: Im Ubuntu-Installer bleibt nur ein repo-spezifisches
apt_get update -ydirekt nach dem Hinzufügen des PostgreSQL-PGDG-Repositories erhalten, damitpostgresql-16dort installierbar bleibt. Der allgemeine Server-Update-/Upgrade-Punkt ist entfernt.