Replace data annotations with glyphs #14378
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e48f06c to
655b208
Compare
655b208 to
43b9f62
Compare
43b9f62 to
24f8ff2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes PR #13344.
This PR reuses most changes from earlier work, but approaches backwards compatibility in a different way.
Arrow,Band,LabelSetandWhikserare preserved, but they are reimplemented usingGlyphRendererand appropriate glyphs (ArrroGlyph,BandGlyph,TextGlyphandWhiskerGlyphrespectively). This is very easily possible due toAnnotation, being aCompositeRenderer. Though minor changes were needed, because composite rendering wasn't utilized much previously.This PR also allows for configurable auto ranging (
Renderer.auto_range), so that glyph renderers constructed by annotations can be removed from range computations. This can, however, be useful on its own and the property is a part of the public API.TODO:
fixes #9955