Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use maybe_initialize for non-deferred HasProps initialization #14431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: branch-4.0
Choose a base branch
from
Open

Use maybe_initialize for non-deferred HasProps initialization #14431

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
617f808
Use maybe_initialize for non-deferred HasProps initialization
ianthomas23 Mar 20, 2025
3686b58
Support new classes
ianthomas23 Mar 20, 2025
3e4e279
Fix remaining bokehjs unit tests
ianthomas23 Mar 26, 2025
eeaa15b
Rewrite regression test for issue #13104
ianthomas23 Apr 25, 2025
d4f8cec
Rewrite regression test for issue #13771
ianthomas23 Apr 25, 2025
df95ad5
Update visual baseline image
ianthomas23 Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Support new classes
  • Loading branch information
@ianthomas23
ianthomas23 committed May 16, 2025
commit 3686b58f218a590cc00bc9944034d8ccd04d1c44
1 change: 1 addition & 0 deletions bokehjs/test/integration/icons.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ export class FlexDiv extends UIElement {

constructor(attrs?: Partial<FlexDiv.Attrs>) {
super(attrs)
this.maybe_initialize(FlexDiv.__name__, attrs)
}

static {
Expand Down
12 changes: 12 additions & 0 deletions bokehjs/test/integration/regressions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3191,6 +3191,11 @@ describe("Bug", () => {
class CustomFigure extends Figure {
declare __view_type__: CustomFigureView

constructor(attrs?: Partial<Figure.Attrs>) {
super(attrs)
this.maybe_initialize(CustomFigure.__name__, attrs)
}

static {
this.prototype.default_view = CustomFigureView
}
Expand Down Expand Up @@ -3908,6 +3913,12 @@ describe("Bug", () => {
}
class MapFigure extends Figure {
declare __view_type__: MapFigureView

constructor(attrs?: Partial<Figure.Attrs>) {
super(attrs)
this.maybe_initialize(MapFigure.__name__, attrs)
}

override use_map = true
static {
this.prototype.default_view = MapFigureView
Expand Down Expand Up @@ -4243,6 +4254,7 @@ describe("Bug", () => {

constructor(attrs?: Partial<FooAttrs>) {
super(attrs)
this.maybe_initialize(Foo.__name__, attrs)
}

static {
Expand Down