Replace deprecated DOMNodeInserted listener with MutationObserver - #44
Merged
Merged
Conversation
Replace deprecated DOMNodeInserted listener with MutationObserver - Resolve Chrome incompatibility when adding collection items or other dynamic nodes - Restore cross-browser support (Chrome, Mozilla, etc.) - Future-proof DOM mutation handling
Member
|
Thanks for your PR! Can you please update your changes so that only what needs to be changed is actually changed? |
Contributor
Author
|
@bobvandevijver |
bobvandevijver
requested changes
May 26, 2025
Co-authored-by: Bob van de Vijver <[email protected]>
Use MutationObserver, rename observer - Replace `DOMNodeInserted` with `MutationObserver` for better performance. - Rename observer to `observerArticle` to prevent naming conflicts. - Initialize editor on page load and for dynamically added nodes.
Contributor
Author
|
@bobvandevijver Is it okay for you regarding the last commit? |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace deprecated DOMNodeInserted listener with MutationObserver