Thanks to visit codestin.com
Credit goes to github.com

Skip to content

core rework/simplification #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dreyfus92 merged 4 commits into from
Apr 28, 2025
Merged

core rework/simplification #308

dreyfus92 merged 4 commits into from
Apr 28, 2025

Conversation

@43081j
Copy link
Collaborator

@43081j 43081j commented Apr 28, 2025

This is a bunch of refactoring on top of the autocomplete prompt which uncovered a whole bunch of possible bugs/awkward code we could fix.

@changeset-bot
Copy link

changeset-bot bot commented Apr 28, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: c1a91d5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Apr 28, 2025 •
edited
Loading

@example/basic • @example/changesets

npm i https://pkg.pr.new/bombshell-dev/clack/@clack/core@308

npm i https://pkg.pr.new/bombshell-dev/clack/@clack/prompts@308

commit: 588d0de

dreyfus92
dreyfus92 approved these changes Apr 28, 2025
View reviewed changes
Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is so good, thank you @43081j

@dreyfus92 dreyfus92 merged commit 9b1ebc5 into feat/autocomplete Apr 28, 2025
5 checks passed
@dreyfus92 dreyfus92 deleted the autocomplete-rework branch April 28, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dreyfus92 dreyfus92 dreyfus92 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@43081j @dreyfus92