The git var GIT_EDITOR fatal behaviour was likely never important #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…was likely never important.
|
The change of git behaviour caused Fedora package builds to fail: https://bugzilla.redhat.com/show_bug.cgi?id=2175807. This patch was included in build https://koji.fedoraproject.org/koji/taskinfo?taskID=98452851 which passed. |
|
An alternative to removing the tests might be to skip them conditionally: --- a/t/20-simple.t
+++ b/t/20-simple.t
@@ -85,6 +85,9 @@
skip "this test does not work with msysgit on Win32", 2
if $^O eq 'MSWin32';
+ skip "'git var GIT_EDITOR' behaviour was changed in git 2.40.0, and we have $version", 2
+ if Git::Repository->version_ge('2.40.0');
+
ok( !eval { $r->run( var => 'GIT_EDITOR' ); 1; }, 'git var GIT_EDITOR' );
like(
$@,Cheers, |
hakonhagland
added a commit
to hakonhagland/Git-Repository
that referenced
this pull request
Sep 28, 2024
|
yep new git doesn't like this test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fatal behaviour was removed from v2.39.0-rc0-2-g2ad150e35e via git/git@2ad150e so it was likely never important.