Test fixes #143
Merged
Test fixes #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename test functions to reflect what they do and enhance test for invalid byte skipping
Prefix all filenames used by the test path, e.g. /foo/test/test_bar-test.txt As each exe has either a unique name or a unique path (build variants in B2) this avoids tests running in parallel accessing the same files which can cause spurious failures.
There may be warnings about a constant condition (over `sizof(CharType)`) which can be avoided using a switch. Also use a cast instead of the union-based type punning to check for endianess
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #143 +/- ##
==========================================
+ Coverage 88.00% 88.04% +0.03%
==========================================
Files 104 104
Lines 9154 9181 +27
==========================================
+ Hits 8056 8083 +27
Misses 1098 1098
Continue to review full report at Codecov.
|
fa3f20a to
25320ef
Compare
25320ef to
c34e0d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix spurious test failures especially for parallel builds via B2 with multiple variants.
This is caused by access to files with fixed names, so different variants of the same test or even different tests using the same filename may interfere with each other.
Also fix a "constant condition" warning in
utf_name()and a bit of refactoring to make the tests easier to read (almost only renaming with no actual change to behavior)