test: Add Packit and gating test #1642
Conversation
cde5644 to
61205f8
Compare
| source /etc/os-release | ||
| case "$ID" in | ||
| "centos") | ||
| BASE="quay.io/centos-bootc/centos-bootc:stream${VERSION_ID}" |
There was a problem hiding this comment.
We keep adding new copies of this...I'd like to consolidate that. here's an random idea. How about we add a field BOOTC_IMAGE into os-release?
But in the intermediate term, I think we could probably have a lib.sh or something that's shared with build.sh too that we use here?
A different idea: Move all the tmt stuff into tests/ and have this "image mapping helper" live in tests?
There was a problem hiding this comment.
Thinking... Create a file with content like BASE_CENOTS_10=quay.io/centos-bootc/centos-bootc:stream10 and source it?
There was a problem hiding this comment.
4fe2142 to
b246f67
Compare
cfea8f4 to
138dc6b
Compare
tmt/plans/packit.fmf
Outdated
| discover+: | ||
| how: fmf | ||
| test: | ||
| - /tmt/tests/test-00-system-reinstall-bootc |
There was a problem hiding this comment.
Can't we do this step not as a test but as a "provision phase" step?
There was a problem hiding this comment.
I'm trying to run this in tmt prepare https://github.com/bootc-dev/bootc/pull/1642/files#diff-bbbfb45ca8f2b20a0985a7efd1f2d17bda0102fb40dcee7f43b6db2ef32a4433R16, and it'll not be a tmt test any more. And it's possible to share same tmt plan (only package mode VM, Packit and gating in this case, run this provision script, github and local run is running on image mode VM) to avoid duplicate plan issue.
| how: tmt | ||
| exit-first: true | ||
|
|
||
| /test-01-readonly: |
There was a problem hiding this comment.
We had an existing problem where "add a new test" requires a lot of ceremony (write the code as a file, write the fmf file, then add it to the plan) - it'd be really great to fix this (can't we use the tmt discover stuff).
But this takes that problem and makes it worse as now all the tests are listed twice more in this file.
There was a problem hiding this comment.
Same as above comment.
| trap 'rm -rf -- "$BOOTC_TEMPDIR"' EXIT | ||
|
|
||
| # Copy files and folders in hack to TEMPDIR | ||
| cp -a ../../hack/* "$BOOTC_TEMPDIR" |
There was a problem hiding this comment.
I think it's a lot cleaner to do cd $BOOTC_TMPDIR and then everything can just reference . below
There was a problem hiding this comment.
The tmt test running folder is at tmt test fmf file folder. The folder id not identical every tmt/testing farm run. So I can't leave this folder before copy all files into $BOOTC_TMPDIR.
8e6d931 to
62cd486
Compare
ab58996 to
8f1f5e0
Compare
Use 'system-reinstall-bootc' to re-install TF runner from package mode to image mode Signed-off-by: Xiaofeng Wang <[email protected]>
Use 'system-reinstall-bootc' to re-install TF runner from package mode to image mode