system-reinstall-bootc: Handle --help #1651
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Code Review
This pull request refactors the command-line argument and configuration file handling in system-reinstall-bootc to correctly process --help. The changes are a good step forward, but the current implementation has a flaw where --help is not handled if the BOOTC_REINSTALL_CONFIG environment variable is set. My review provides suggestions to fix this by always parsing CLI arguments first, which ensures --help works correctly in all scenarios. I've also included recommendations to improve error reporting and to expand the new test case to cover this edge case.
I wanted to add a CLI option here to avoid the reboot, and ran into the fact that our option parsing was suboptimal to start with. We never documented `BOOTC_REINSTALL_CONFIG` at all...I'm kind of tempted to deprecate it. Signed-off-by: Colin Walters <[email protected]>
4149066 to
84519fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to add a CLI option here to avoid the reboot, and ran into the fact that our option parsing was suboptimal to start with.
We never documented
BOOTC_REINSTALL_CONFIGat all...I'm kind of tempted to deprecate it.