Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(b-modal): fix scroll to top issue when modal has no-fade set (closes #4003) #4004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 3, 2019
Merged

fix(b-modal): fix scroll to top issue when modal has no-fade set (closes #4003) #4004

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8903d8e
fix(modal): fix scroll to top issue when modal has `no-fade` set
tmorehouse Sep 3, 2019
aea02f3
Merge branch 'dev' into issue/4003
tmorehouse Sep 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/components/modal/modal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -775,11 +775,14 @@ export const BModal = /*#__PURE__*/ Vue.extend({
: autoFocus === 'close' && close
? close.$el || close
: content
// Make sure top of modal is showing (if longer than the viewport)
// Focus the element
attemptFocus(el)
if (el === content) {
modal.scrollTop = 0
// Make sure top of modal is showing (if longer than the viewport)
this.$nextTick(() => {
modal.scrollTop = 0
})
}
attemptFocus(el)
}
})
}
Expand Down