Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(b-modal): add optional trigger parameter to $bvModal.hide() method #6523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

feat(b-modal): add optional trigger parameter to $bvModal.hide() method #6523

wants to merge 6 commits into from

Conversation

Hiws
Copy link
Member

@Hiws Hiws commented Mar 25, 2021 •
edited by cdmoro
Loading

Describe the PR

This PR allows for the passing of a trigger, using the $bvModal.hide method.
This is currently possible via either a ref, which can be used to access the hide method in <b-modal>, or the same hide method exposed in various scoped slots of <b-modal>.

I believe this change would allow better flexibility when using the modals on demand.

It might also be worth removing the "protected" prop, hideFooter: false, from the following snippet.

bootstrap-vue/src/components/modal/helpers/bv-modal.js

Lines 215 to 229 in b2b5c7b

msgBoxOk(message, options = {}) {
// Pick the modal props we support from options
const props = {
...options,
// Add in overrides and our content prop
okOnly: true,
okDisabled: false,
hideFooter: false,
msgBoxContent: message
}
return makeMsgBox(this._vm, message, props, () => {
// Always resolve to true for OK
return true
})
}

In case users would like to create their own cancel and ok buttons while hiding the default ones.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix (fixes a boo-boo in the code) - fix(...), requires a patch version update
  • Feature (adds a new feature to BootstrapVue) - feat(...), requires a minor version update
  • Enhancement (augments an existing feature) - feat(...), requires a minor version update
  • ARIA accessibility (fixes or improves ARIA accessibility) - fix(...), requires a patch or minor version update
  • Documentation update (improves documentation or typo fixes) - chore(docs), requires a patch version update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe since breaking changes require a minor version update)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc.). This is very important, as the CHANGELOG is generated from these messages, and determines the next version type (patch or minor).

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates
  • Includes component package.json meta section updates (prop, slot and event changes/updates)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (required for new features and enhancements)
  • Existing test suites are passing
  • CodeCov for patch has met target (all changes/updates have been tested)
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@Hiws Hiws added Type: Enhancement PR: Patch Requires patch version bump labels Mar 25, 2021
@Hiws Hiws requested a review from jacobmllr95 March 25, 2021 04:14
@vercel
Copy link

vercel bot commented Mar 25, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/bootstrap-vue/bootstrap-vue/GBcs9EB4bBG6YkK5SiXaMuzGfLac
✅ Preview: https://bootstrap-vue-git-fork-hiws-update-bvmodal-hide-method-60499d.vercel.app

@Hiws Hiws changed the title feat(b-modal): Add optional trigger paramater to $bvModal.hide feat(b-modal): Add optional trigger parameter to $bvModal.hide Mar 25, 2021
@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 25, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d58c113:

Sandbox Source
BootstrapVue Starter Project Configuration
BootstrapVue Nuxt.js Starter Project Configuration

@codecov
Copy link

codecov bot commented Mar 25, 2021 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3d7f4c7) to head (d58c113).
Report is 226 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev     #6523   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          299       299           
  Lines        10211     10211           
  Branches      2521      2522    +1     
=========================================
  Hits         10211     10211
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Hiws Hiws mentioned this pull request Mar 25, 2021
Closed
@jacobmllr95 jacobmllr95 added PR: Minor Requires minor version bump and removed PR: Patch Requires patch version bump labels Apr 21, 2021
@jacobmllr95 jacobmllr95 changed the title feat(b-modal): Add optional trigger parameter to $bvModal.hide feat(b-modal): add optional trigger parameter to $bvModal.hide() method Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobmllr95 jacobmllr95 Awaiting requested review from jacobmllr95

Assignees
No one assigned
Labels
PR: Minor Requires minor version bump Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hiws @jacobmllr95