-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix(b-table): set aria-sort
when using sortKey
and no-local-sorting
(closes #6602)
#6603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(b-table): set aria-sort
when using sortKey
and no-local-sorting
(closes #6602)
#6603
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/bootstrap-vue/bootstrap-vue/3NBZgYvhLerhiEfpFKst3zL65M52 |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 547840f:
|
Codecov Report
@@ Coverage Diff @@
## dev #6603 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 299 299
Lines 10211 10213 +2
Branches 2521 2522 +1
=========================================
+ Hits 10211 10213 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
aria-sort
when using sortKey
and no-local-sorting
(fixed #6602)aria-sort
when using sortKey
and no-local-sorting
(fixed #6602)
aria-sort
when using sortKey
and no-local-sorting
(fixed #6602)aria-sort
when using sortKey
and no-local-sorting
(closes #6602)
Describe the PR
Fixes an issue where
aria-sort
wasn't being correctly set on fields that used asortKey
andno-local-sorting
was set on<b-table>
.It should now correctly set them when sorting that column.
Closes #6602.
Working example: https://codesandbox.io/s/bootstrapvue-starter-project-forked-3b7pt?file=/App.vue
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...)
, requires a patch version updatefeat(...)
, requires a minor version updatefeat(...)
, requires a minor version updatefix(...)
, requires a patch or minor version updatechore(docs)
, requires a patch version updateDoes this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples
,chore(docs): fix typo in README
, etc.). This is very important, as theCHANGELOG
is generated from these messages, and determines the next version type (patch or minor).If new features/enhancement/fixes are added or changed: