add pyfuse3 as an alternative lowlevel fuse implementation#5430
Merged
ThomasWaldmann merged 2 commits intoborgbackup:masterfrom Nov 2, 2020
Merged
add pyfuse3 as an alternative lowlevel fuse implementation#5430ThomasWaldmann merged 2 commits intoborgbackup:masterfrom
ThomasWaldmann merged 2 commits intoborgbackup:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5430 +/- ##
==========================================
- Coverage 83.69% 83.62% -0.08%
==========================================
Files 37 38 +1
Lines 9957 9982 +25
Branches 1656 1661 +5
==========================================
+ Hits 8334 8347 +13
- Misses 1142 1151 +9
- Partials 481 484 +3
Continue to review full report at Codecov.
|
900f2ec to
261d042
Compare
Gu1nness
suggested changes
Oct 21, 2020
Contributor
Gu1nness
left a comment
There was a problem hiding this comment.
- I would add a test where BORG_FUSE_IMPL is set to an empty variable to ensure that it crashed the way we want to avoid regressions in the future.
- The documentation needs to be updated to be indented the way we should.
- I have run all the tests and it seems to be working (fuse2 and fuse3)
FUSE implementation can be switched via env var BORG_FUSE_IMPL.
0dfa430 to
cebc5bf
Compare
Member
Author
|
Squashed the fixup, reword another commit comment. Will merge after tests complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.