UI fixes and tests #137
Merged
UI fixes and tests #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gradle now places the compiled class file under a different path.
2.9.6 has a deserialization vulnerability: https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-72450
The FFmpeg service needs to be mocked out, which requires mocking a static method. The PowerMock framework supports this.
This is so that unit test can access these.
When the media container was changed it resulted in the custom video resolution option appearing. However, this should only appear if the video resolution is set to 'custom'.
Previously if the video bitrate was invalid encoding to GIF would be rejected. The video bitrate is not used for GIF, so it can be safely ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few fixes in the UI:
as well as adding robolectric unit tests for the main activity