This repository was archived by the owner on Jan 4, 2019. It is now read-only.
Conversation
bridiver
commented
Aug 30, 2018
| // Stop intercepting keyboard events. | ||
| virtual void UnlockKeyboard() = 0; | ||
|
|
||
| +#if !defined(MUON_CHROMIUM_BUILD) |
Collaborator
Author
There was a problem hiding this comment.
I'm not sure I understand what's going on with this change
450fd34#diff-868023d36d447ab80b508fc483ead7ef makes it only gc once Auditor: @bridiver, @ltilve
Auditor: @briiver
Add API method: electron.app.getCountryName
including "//content/public/browser" deps in order to access blink mojo bindings
With https://chromium.googlesource.com/chromium/src/+/f623bafe9c5b8cbd1d63c4d7c9b69de172552df5, the values were changed from an exclusion (ex: which values to NOT put in `OverlayUserPrefStore`) to an inclusion (ex: which values to PERSIST, even in an incognito profile) Fixes brave/browser-laptop#15191
Update incognito session initialization
… other Allow* methods in the observer
Issue: 15232 AllowScript should use atom::ContentSettingsManager like other Allow* methods in the observer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.