Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove broken tests with external dependency #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2017

Conversation

charmander
Copy link
Collaborator

Yikes.

@charmander charmander requested a review from brianc February 8, 2017 07:53
Copy link
Owner

@brianc brianc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yah probably better to remove this - flaky and too brittle, plus having creds in the code is no bueno. This is a holdover I put in years ago to test some heroku specific stuff that's no longer needed.

@brianc brianc merged commit 5b6d883 into brianc:master Feb 13, 2017
@charmander charmander deleted the remove-broken-tests branch February 13, 2017 09:29
ianmdawson pushed a commit to Shyp/node-postgres that referenced this pull request Aug 18, 2017
simon-contreras-deel added a commit to CartoDB/node-postgres that referenced this pull request Aug 29, 2017
simon-contreras-deel added a commit to CartoDB/node-postgres that referenced this pull request Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants