ed: implement ! command #405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mknos
commented
Jan 10, 2024
- Take a hint from the TODO comments
- The big regex in edParse() doesn't help because spaces have a special meaning; the new branch bypasses it
- "!" line is printed at end of command output (or after error message if command can't be started)
- Ignore if the command exits with non-zero status; print error only if command doesn't start
- edPipe() doesn't take any line addresses because the output is not saved into the buffer
- Tested against GNU and OpenBSD versions
- test1: shell pattern: "!for i in 1 2 3; do echo $i; done"
- test2: zero exit status command: "!ls"
- test3: non-zero exit status command: "!false"
* Take a hint from the TODO comments * The big regex in edParse() doesn't help because spaces have a special meaning; the new branch bypasses it * "!" line is printed at end of command output (or after error message if command can't be started) * Ignore if the command exits with non-zero status; print error only if command doesn't start * Tested against GNU and OpenBSD versions * test1: shell pattern: "!for i in 1 2 3; do echo $i; done" * test2: zero exit status command: "!ls" * test3: non-zero exit status command: "!false"
briandfoy
requested changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.