Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Command + enter to submit forms#653

Merged
brianlovin merged 3 commits into
masterfrom
jfm
May 10, 2020
Merged

Command + enter to submit forms#653
brianlovin merged 3 commits into
masterfrom
jfm

Conversation

@brianlovin

Copy link
Copy Markdown
Owner

No description provided.

@vercel

vercel Bot commented May 10, 2020

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/brianlovin/brian-lovin-next/cm01zzuq6
✅ Preview: https://brian-lovin-next-git-jfm.brianlovin.now.sh

@accesslint accesslint Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

placeholder="Notes..."
onChange={onNotesChange}
onKeyDown={onKeyDown}
/>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input.

@github-actions

Copy link
Copy Markdown
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 21.1%, saving 2.92 KB

Filename Before After Improvement
public/static/img/overthought/just-for-me-authentication.png 13.84 KB 10.92 KB -21.1%
Some images were already optimised
  • public/static/img/about.jpg
  • public/static/img/overthought/2019-in-review.png
  • public/static/img/overthought/adding-dark-mode-with-next-js.png
  • public/static/img/overthought/automating-the-boring-parts-of-product-design.png
  • public/static/img/overthought/caching-api-routes-with-next-js.png
  • public/static/img/overthought/cookies-authenticate-next-js-apollo-graphql-requests.png
  • public/static/img/overthought/death-of-designer-unicorns.png
  • public/static/img/overthought/incrementally-correct-personal-websites.png
  • public/static/img/overthought/investing-for-designers-and-developers.png
  • public/static/img/overthought/migrating-from-google-analytics-to-fathom.png
  • public/static/img/overthought/on-working-nights-and-weekends.png
  • public/static/img/overthought/product-design-portfolios.png
  • public/static/img/overthought/the-meta-skills-of-product-design.png
  • public/static/img/overthought/using-ghost-headless-cms-next-js-to-create-a-fast-and-simple-blog.png
  • public/static/img/podcasts/designdetails.jpg
  • public/static/img/subscription_icons/breaker.png
  • public/static/img/subscription_icons/castro.png
  • public/static/img/subscription_icons/google-podcasts.png
  • public/static/img/subscription_icons/overcast.png
  • public/static/img/subscription_icons/pocketcasts.png
  • public/static/img/subscription_icons/podcasts.png
  • public/static/img/subscription_icons/rss.png
  • public/static/img/subscription_icons/spotify.png
  • public/static/meta/ama.png
  • public/static/meta/app-dissection.png
  • public/static/meta/apple-touch-icon.png
  • public/static/meta/bookmarks.png
  • public/static/meta/google-touch-icon.png
  • public/static/meta/og-image.png
  • public/static/meta/overthought.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant