fixed the bug of only web in gmail_2fa_integration.py #2685
Conversation
…f web application oauth, not in case of other like desktop application
|
|
There was a problem hiding this comment.
cubic analysis
No issues found across 1 file. Review in cubic
|
Also while checking for seeing why the tests fails I noticed that _browser_context has been used in test_browser_session_start.py but actually there is no such method or property in BrowserSession class, hence it throws error due to which test fails. |
Solves the issue: #2581
So earlier it checks only for web in secret json but it will break and not work if in oauth we have desktop or other app, hence need to have support for that as well so added that and fixed.
Earlier, before fixing
After fixing
Summary by cubic
Updated the Gmail 2FA integration script to support credentials files with both "web" and "installed" sections, fixing errors for desktop app OAuth setups.
Besides this I have also checked the ./bin/test.sh and ./bin/lint.sh, there are some fails but that is not due to my code, it is failing in other files that I have not changed.