fix-browser-start #2844
Merged
fix-browser-start #2844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd remove deprecated `stealth` option. Adjust remote browser examples to reflect changes in parameter handling.
Agent Task Evaluation Results: 0/3 (0%)View detailed results
Check the evaluate-tasks job for detailed task execution logs. |
| ) | ||
| cdp_url="http://remote-server:9222", | ||
| is_local=False # set to True if you want to use a local browser | ||
| cdp_url="http://remote-server:9222" |
There was a problem hiding this comment.
cdp_url is not separated by a comma from the previous argument, causing a syntax error in this example.
Prompt for AI agents
Address the following comment on docs/customize/browser/remote.mdx at line 46:
<comment>cdp_url is not separated by a comma from the previous argument, causing a syntax error in this example.</comment>
<file context>
@@ -44,8 +43,7 @@ browser = Browser(
)
- cdp_url="http://remote-server:9222",
- is_local=False # set to True if you want to use a local browser
+ cdp_url="http://remote-server:9222"
)
</file context>
Suggested change
| cdp_url="http://remote-server:9222" | |
| , cdp_url="http://remote-server:9222" |
| - Use list like `['*.google.com', 'https://example.com', 'chrome-extension://*']` | ||
| - `enable_default_extensions` (default: `True`): Load automation extensions (uBlock Origin, cookie handlers, ClearURLs) | ||
| - `cross_origin_iframes` (default: `False`): Enable cross-origin iframe support (may cause complexity) | ||
| - `is_local` (default: `True`): Whether this is a local browser instance. Set to `False` for remote browsers. If we have a `executable_path` set, it will be automatically set to `True`. This can effect your download behavior. |
There was a problem hiding this comment.
Docs state is_local default True, but code default is False; this mismatch can cause startup errors without cdp_url.
Prompt for AI agents
Address the following comment on docs/customize/browser/all-parameters.mdx at line 32:
<comment>Docs state is_local default True, but code default is False; this mismatch can cause startup errors without cdp_url.</comment>
<file context>
@@ -31,6 +29,7 @@ mode: "wide"
- Use list like `['*.google.com', 'https://example.com', 'chrome-extension://*']`
- `enable_default_extensions` (default: `True`): Load automation extensions (uBlock Origin, cookie handlers, ClearURLs)
- `cross_origin_iframes` (default: `False`): Enable cross-origin iframe support (may cause complexity)
+- `is_local` (default: `True`): Whether this is a local browser instance. Set to `False` for remote browsers. If we have a `executable_path` set, it will be automatically set to `True`. This can effect your download behavior.
## User Data & Profiles
</file context>
| # Session/connection configuration | ||
| cdp_url: str | None = Field(default=None, description='CDP URL for connecting to existing browser instance') | ||
| is_local: bool = Field(default=True, description='Whether this is a local browser instance') | ||
| is_local: bool = Field(default=False, description='Whether this is a local browser instance') |
There was a problem hiding this comment.
Changing is_local default to False makes default sessions without cdp_url raise at startup instead of launching a local browser, breaking expected default behavior.
(This reflects your team's feedback about matching the project's tab indentation in suggestions.)
Prompt for AI agents
Address the following comment on browser_use/browser/profile.py at line 539:
<comment>Changing is_local default to False makes default sessions without cdp_url raise at startup instead of launching a local browser, breaking expected default behavior.
(This reflects your team's feedback about matching the project's tab indentation in suggestions.)</comment>
<file context>
@@ -536,11 +536,10 @@ class BrowserProfile(BrowserConnectArgs, BrowserLaunchPersistentContextArgs, Bro
# Session/connection configuration
cdp_url: str | None = Field(default=None, description='CDP URL for connecting to existing browser instance')
- is_local: bool = Field(default=True, description='Whether this is a local browser instance')
+ is_local: bool = Field(default=False, description='Whether this is a local browser instance')
# label: str = 'default'
</file context>
Suggested change
| is_local: bool = Field(default=False, description='Whether this is a local browser instance') | |
| is_local: bool = Field(default=True, description='Whether this is a local browser instance') |
| id: str | None = None, | ||
| cdp_url: str | None = None, | ||
| is_local: bool = True, | ||
| is_local: bool = False, |
There was a problem hiding this comment.
Default is_local=False breaks default local launch; start() now raises when cdp_url is missing.
Prompt for AI agents
Address the following comment on browser_use/browser/session.py at line 221:
<comment>Default is_local=False breaks default local launch; start() now raises when cdp_url is missing.</comment>
<file context>
@@ -219,7 +218,7 @@ def __init__(
id: str | None = None,
cdp_url: str | None = None,
- is_local: bool = True,
+ is_local: bool = False,
browser_profile: BrowserProfile | None = None,
# BrowserProfile fields that can be passed directly
</file context>
| - Use list like `['*.google.com', 'https://example.com', 'chrome-extension://*']` | ||
| - `enable_default_extensions` (default: `True`): Load automation extensions (uBlock Origin, cookie handlers, ClearURLs) | ||
| - `cross_origin_iframes` (default: `False`): Enable cross-origin iframe support (may cause complexity) | ||
| - `is_local` (default: `True`): Whether this is a local browser instance. Set to `False` for remote browsers. If we have a `executable_path` set, it will be automatically set to `True`. This can effect your download behavior. |
There was a problem hiding this comment.
Fix grammar in the added docs line: use "an" before executable_path and "affect" (not "effect") for clarity.
(Based on your team's feedback about aligning suggestions with indentation style, the fix preserves the existing list formatting.)
Prompt for AI agents
Address the following comment on docs/customize/browser/all-parameters.mdx at line 32:
<comment>Fix grammar in the added docs line: use "an" before `executable_path` and "affect" (not "effect") for clarity.
(Based on your team's feedback about aligning suggestions with indentation style, the fix preserves the existing list formatting.)</comment>
<file context>
@@ -31,6 +29,7 @@ mode: "wide"
- Use list like `['*.google.com', 'https://example.com', 'chrome-extension://*']`
- `enable_default_extensions` (default: `True`): Load automation extensions (uBlock Origin, cookie handlers, ClearURLs)
- `cross_origin_iframes` (default: `False`): Enable cross-origin iframe support (may cause complexity)
+- `is_local` (default: `True`): Whether this is a local browser instance. Set to `False` for remote browsers. If we have a `executable_path` set, it will be automatically set to `True`. This can effect your download behavior.
## User Data & Profiles
</file context>
Suggested change
| - `is_local` (default: `True`): Whether this is a local browser instance. Set to `False` for remote browsers. If we have a `executable_path` set, it will be automatically set to `True`. This can effect your download behavior. | |
| - `is_local` (default: `True`): Whether this is a local browser instance. Set to `False` for remote browsers. If an `executable_path` is set, it will be automatically set to `True`. This can affect your download behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto-generated PR for branch: fix-browser-start
Summary by cubic
Fail fast on browser startup and simplify configuration. BrowserStartEvent now raises on startup errors, is_local defaults to False with auto-detection when executable_path is set, and the deprecated stealth option is removed.
Bug Fixes
Migration