fix: improve StorageStateWatchdog lifecycle management #2853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add BrowserStopEvent handler to properly stop monitoring when browser closes - Await LoadStorageStateEvent dispatch to ensure storage is loaded before navigation - Clean up monitoring task on browser stop to prevent CDP connection errors This ensures storage state is properly loaded before the browser starts navigating and prevents error logs from monitoring attempts after the browser has closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix StorageStateWatchdog lifecycle management
Problem
StorageStateWatchdog continues monitoring after browser closes, causing CDP connection errors in logs.
Solution
BrowserStopEventhandler to cleanly stop monitoring when browser closesLoadStorageStateEventdispatch to ensure storage loads before navigationImpact
StorageStateWatchdogis commented out inattach_all_watchdogs()Summary by cubic
Stop StorageStateWatchdog when the browser closes and await storage load on connect. This prevents CDP connection errors after shutdown and ensures cookies/auth are loaded before navigation.