fix-windowsVirtualKeyCode #2871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Agent Task Evaluation Results: 2/3 (67%)View detailed results
Check the evaluate-tasks job for detailed task execution logs. |
| return (0, no_shift_chars[char], char) | ||
|
|
||
| # Fallback | ||
| return (0, ord(char.upper()) if char.isalpha() else ord(char), char) |
There was a problem hiding this comment.
Fallback assigns invalid windowsVirtualKeyCode values for non-ASCII chars; use 0 for characters without a defined VK to avoid incorrect key events.
(Based on your team's feedback about matching indentation style, the fix suggestion keeps tab indentation.)
Prompt for AI agents
Address the following comment on browser_use/browser/watchdogs/default_action_watchdog.py at line 653:
<comment>Fallback assigns invalid windowsVirtualKeyCode values for non-ASCII chars; use 0 for characters without a defined VK to avoid incorrect key events.
(Based on your team's feedback about matching indentation style, the fix suggestion keeps tab indentation.)</comment>
<file context>
@@ -582,6 +582,76 @@ async def _type_to_page(self, text: str):
+ return (0, no_shift_chars[char], char)
+
+ # Fallback
+ return (0, ord(char.upper()) if char.isalpha() else ord(char), char)
+
def _get_key_code_for_char(self, char: str) -> str:
</file context>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto-generated PR for: fix-windowsVirtualKeyCode
Summary by cubic
Fixes Windows virtual key code handling for simulated typing to match Chrome DevTools behavior. Prevents wrong characters (e.g., !, @, uppercase) and improves reliability of text input on Windows.