highlight in parallel #2873
Merged
highlight in parallel #2873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Agent Task Evaluation Results: 0/3 (0%)View detailed results
Check the evaluate-tasks job for detailed task execution logs. |
|
|
||
| # Execute all element processing tasks in parallel | ||
| if tasks: | ||
| await asyncio.gather(*tasks, return_exceptions=True) |
There was a problem hiding this comment.
Bug: Async Highlighting Fails Due to ImageDraw Thread Safety
The create_highlighted_screenshot function attempts parallel highlighting with asyncio.gather, but process_element_highlight is synchronous, adding overhead without performance gain. Multiple tasks concurrently modify the shared PIL ImageDraw object, which is not thread-safe and can corrupt the screenshot's highlights.
| import time | ||
| from typing import TYPE_CHECKING | ||
|
|
||
| from utils import time_execution_async |
There was a problem hiding this comment.
Incorrect import path causes runtime ImportError; utils is not a top-level module in this package. Use the package-qualified import instead.
(Based on your team's feedback about matching the project's tab-based indentation style, the one-line fix follows your formatting conventions.)
Prompt for AI agents
Address the following comment on browser_use/browser/watchdogs/dom_watchdog.py at line 7:
<comment>Incorrect import path causes runtime ImportError; utils is not a top-level module in this package. Use the package-qualified import instead.
(Based on your team's feedback about matching the project's tab-based indentation style, the one-line fix follows your formatting conventions.)</comment>
<file context>
@@ -4,6 +4,8 @@
import time
from typing import TYPE_CHECKING
+from utils import time_execution_async
+
from browser_use.browser.events import (
</file context>
Suggested change
| from utils import time_execution_async | |
| from browser_use.utils import time_execution_async |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto-generated PR for: highlight in parallel
Summary by cubic
Render element highlights in parallel and add timing to key paths to speed up screenshot annotation. This makes highlighting faster on pages with many elements.