update-sensitive-data-docs #2911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Agent Task Evaluation Results: 2/3 (67%)View detailed results
Check the evaluate-tasks job for detailed task execution logs. |
| 'x_pass': 'your-real-password123', | ||
| }, | ||
| }, | ||
| sensitive_data=sensitive_data, |
There was a problem hiding this comment.
Bug: Credentials Misconfiguration Exposes Security Vulnerabilities
The sensitive_data configuration in this example was changed from a domain-scoped dictionary to a flat dictionary of credentials. This removes the security feature of restricting credentials to specific domains, making them available to all websites the agent visits. It also likely causes runtime errors, as the API expects a domain-specific structure.
| ```bash create environment | ||
| python -m venv .venv | ||
| ```bash create environment with python >= 3.11 | ||
| python3.12 -m venv .venv |
There was a problem hiding this comment.
Hardcoding python3.12 unnecessarily narrows supported setups; use the active Python to align with the stated ">=3.11" support and pyproject's requires-python.
Prompt for AI agents
Address the following comment on docs/quickstart.mdx at line 18:
<comment>Hardcoding python3.12 unnecessarily narrows supported setups; use the active Python to align with the stated ">=3.11" support and pyproject's requires-python.</comment>
<file context>
@@ -9,13 +9,13 @@ icon: "rocket"
-```bash create environment
-python -m venv .venv
+```bash create environment with python >= 3.11
+python3.12 -m venv .venv
</Tab>
</file context>
</details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto-generated PR for: update-sensitive-data-docs
Summary by cubic
Update sensitive-data docs to show both global and domain-scoped secrets (with regex) and use a single sensitive_data variable in the Agent example. Quickstart now clarifies Python version (>=3.11, example with python3.12) and installs Playwright explicitly before installing Chromium deps.