Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix-popup-handling #2956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 4, 2025
Merged

fix-popup-handling #2956

merged 2 commits into from
Sep 4, 2025

Conversation

MagMueller
Copy link
Collaborator

@MagMueller MagMueller commented Sep 4, 2025 •
edited by cubic-dev-ai bot
Loading

Auto-generated PR for branch: fix-popup-handling

Summary by cubic

Fixes JavaScript popup handling by auto-dismissing alerts/confirm/prompts immediately via CDP across all frames. Simplifies the flow to prevent crashes and focus issues, and makes DialogOpenedEvent.frame_id optional for missing CDP frameIds.

  • Bug Fixes

    • Register Page.javascriptDialogOpening on both session and root CDP clients to catch dialogs from any frame.
    • Dismiss dialogs with Page.handleJavaScriptDialog using session fallbacks (detected session → agent focus) with short timeouts.
    • PopupsWatchdog no longer listens to or emits DialogOpenedEvent; it only listens to TabCreatedEvent.

  • Migration

    • If you relied on DialogOpenedEvent from PopupsWatchdog, remove those listeners; dialogs are now dismissed silently.
    • DialogOpenedEvent.frame_id is now optional (can be None); update any strict type checks.

cursor[bot]

This comment was marked as outdated.

Sign in to view

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2025 •
edited
Loading

Agent Task Evaluation Results: 1/3 (33%)

View detailed results
Task Result Reason
amazon_laptop ✅ Pass The agent successfully navigated to amazon.com, performed a search for 'laptop', and returned the name of the first laptop result along with additional relevant details such as price, rating, and a link. This meets all the criteria for success.
browser_use_pip ❌ Fail The agent did not provide the required pip installation command 'pip install browser-use' as specified in the success criteria. Instead, it reported that no such command was found in the repository. Therefore, the task was not successfully completed.
captcha_cloudflare ❌ Fail The agent failed to solve the captcha and did not extract the 'hostname' value as required. The output indicates that due to interaction limitations in the environment, the agent could not complete the task, resulting in failure to meet the success criteria.

Check the evaluate-tasks job for detailed task execution logs.

cubic-dev-ai[bot]
cubic-dev-ai bot reviewed Sep 4, 2025
View reviewed changes
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 2 files

React with 👍 or 👎 to teach cubic. You can also tag @cubic-dev-ai to give feedback, ask questions, or re-run the review.

@MagMueller
Update PopupsWatchdog to automatically accept JavaScript dialogs inst…
770955e 
…ead of dismissing them. Adjust logging messages accordingly and remove unused post-dialog recovery method.
@MagMueller MagMueller merged commit bf85863 into main Sep 4, 2025
53 checks passed
@MagMueller MagMueller deleted the fix-popup-handling branch September 4, 2025 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

@cursor cursor[bot] cursor[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MagMueller