enable StorageStateWatchdog if user_data_dir provided #2987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Agent Task Evaluation Results: 2/4 (50%)View detailed results
Check the evaluate-tasks job for detailed task execution logs. |
| # Initialize StorageStateWatchdog conditionally | ||
| # Enable when user provides either storage_state or user_data_dir (indicating they want persistence) | ||
| should_enable_storage_state = ( | ||
| self.browser_profile.storage_state is not None or self.browser_profile.user_data_dir is not None |
There was a problem hiding this comment.
Enabling the watchdog when only user_data_dir is set starts monitoring but cannot save/load without a storage_state path, adding overhead without effect. Consider deriving a default path from user_data_dir or gating enablement on storage_state.
Prompt for AI agents
Address the following comment on browser_use/browser/session.py at line 1003:
<comment>Enabling the watchdog when only user_data_dir is set starts monitoring but cannot save/load without a storage_state path, adding overhead without effect. Consider deriving a default path from user_data_dir or gating enablement on storage_state.</comment>
<file context>
@@ -997,14 +997,27 @@ async def attach_all_watchdogs(self) -> None:
+ # Initialize StorageStateWatchdog conditionally
+ # Enable when user provides either storage_state or user_data_dir (indicating they want persistence)
+ should_enable_storage_state = (
+ self.browser_profile.storage_state is not None or self.browser_profile.user_data_dir is not None
+ )
+
</file context>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto-generated PR for: enable StorageStateWatchdog if user_data_dir provided
Summary by cubic
Enable StorageStateWatchdog when storage_state or user_data_dir is set, so sessions with persistence configured save storage on shutdown with safe defaults. Adds clear debug logs to show when it’s enabled.