fix-downloads-dedup-clean #2989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…; disable local JS fetch
…eep tab indentation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Agent Task Evaluation Results: 3/4 (75%)View detailed results
Check the evaluate-tasks job for detailed task execution logs. |
This commit updates the DownloadsWatchdog class to ensure that the downloads directory path is properly expanded and resolved to an absolute path. The changes include: - Expanding the downloads path using `expanduser()` and `resolve()` methods to handle user home directories correctly. - Updating the download behavior settings to use the expanded path. - Ensuring that the downloads directory is created with the resolved path. Additionally, the example feature for downloading files has been modified to use a temporary downloads path for testing purposes.
This commit modifies the `download_file.py` example to replace the `BrowserSession` and `BrowserProfile` with the new `Browser` class. The changes streamline the code and enhance clarity by directly utilizing the `Browser` for managing downloads. The download path remains set to a temporary directory for testing purposes.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This commit updates the DownloadsWatchdog class to specify exception types in the error handling logic, replacing broad exception catches with more precise ones (AssertionError, KeyError, AttributeError). Additionally, it adds a warning log when no downloads path is configured, ensuring better error visibility and handling during download operations.
| # Skip if already handled by progress/JS fetch | ||
| info = self._cdp_downloads_info.get(guid, {}) | ||
| if info.get('handled'): | ||
| return |
There was a problem hiding this comment.
Bug: Download Deduplication Fails with Empty GUIDs
The new download deduplication logic can incorrectly skip downloads. If a GUID is empty, multiple downloads might share a 'handled' status. In the polling loop, the deduplication check uses the initial event's GUID, which can skip legitimate concurrent downloads. Also, downloads detected via polling are no longer tracked in browser_session._downloaded_files, leading to inconsistent tracking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto-generated PR for branch: fix-downloads-dedup-clean
Summary by cubic
Fixes duplicate local download events by ensuring each download is dispatched once, and hardens download handling for both local and remote sessions.