ignore asci for chinese letters #2992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Agent Task Evaluation Results: 3/4 (75%)View detailed results
Check the evaluate-tasks job for detailed task execution logs. |
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
|
|
||
| screenshot.png | ||
|
|
||
| # *.md |
There was a problem hiding this comment.
Bug: Markdown Files Not Ignored As Expected
The .gitignore update added # *.md, which is a commented line. This prevents Markdown files from being ignored, contrary to the PR's stated intention to add an active ignore rule for *.md files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto-generated PR for: ignore asci for chinese letters
Summary by cubic
Preserves Chinese and other non-ASCII characters in extracted_content by serializing JSON with ensure_ascii=False. Also updates .gitignore to ignore Markdown files (*.md).