Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Paint order filtering #3007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 8, 2025
Merged

Paint order filtering #3007

merged 7 commits into from
Sep 8, 2025

Conversation

gregpr07
Copy link
Member

@gregpr07 gregpr07 commented Sep 8, 2025 •
edited by cubic-dev-ai bot
Loading

Summary by cubic

Add paint-order-based filtering to DOM serialization to hide elements fully covered by later-painted layers. This reduces noisy nodes, improves relevance, and is enabled by default via BrowserProfile.paint_order_filtering.

  • New Features

    • Added PaintOrderRemover with rectangle-union occlusion by paint_order and bounds; marks nodes as ignored_by_paint_order.
    • Serializer runs paint-order pass before optimization; skips interactive indexing for ignored nodes.
    • Considers background-color and opacity; ignores transparent backgrounds and opacity < 0.8 when building occlusion.
    • Added paint_order_filtering flag to BrowserProfile, Session, and DomService; playground wired for testing.
    • Included background-color in computed styles; added guards to timing percent calculations.

  • Migration

    • Serialized output now includes ignored_by_paint_order (SimplifiedNode) and is_visible (EnhancedDOMTreeNode).
    • To disable, set paint_order_filtering=False on BrowserProfile, BrowserSession, or DomService.

cubic-dev-ai[bot]
cubic-dev-ai bot reviewed Sep 8, 2025
View reviewed changes
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6 issues found across 9 files

React with 👍 or 👎 to teach cubic. You can also tag @cubic-dev-ai to give feedback, ask questions, or re-run the review.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 8, 2025 •
edited
Loading

Agent Task Evaluation Results: 1/4 (25%)

View detailed results
Task Result Reason
amazon_laptop ✅ Pass The agent successfully navigated to amazon.com, performed a search for 'laptop', and returned the name and details of the first laptop result, fulfilling all the criteria for success.
google_maps_3d ❌ Fail The agent successfully used www.google.com/maps and searched for ETH Zurich Hauptgebäude, closed the side panel, and switched to Satellite View. However, it failed to enable 3D mode because the 3D Earth view was unavailable. Additionally, the map was not panned sufficiently to clearly show both ETH Zurich Hauptgebäude and Zurich Lake together, and no screenshot was captured. Therefore, the task was only partially completed and does not meet all success criteria.
browser_use_pip ❌ Fail The agent did not provide the required 'pip install browser-use' command as specified in the task. Instead, it explained that the repository uses a custom installer 'uv' and provided related commands. Since the task explicitly required the pip installation command, and it was not given, the output does not meet the success criteria.
captcha_cloudflare ❌ Fail The agent successfully solved the captcha but failed to click the 'Check' button, wait for completion, and extract the 'hostname' value from the success message as required. Since the hostname extraction and final confirmation steps were not completed, the task is incomplete and does not meet the success criteria.

Check the evaluate-tasks job for detailed task execution logs.

@gregpr07 gregpr07 linked an issue Sep 8, 2025 that may be closed by this pull request
Interaction Issue: Element highlighting incorrectly includes iframe content when modal is open #2519
Closed
@gregpr07 gregpr07 enabled auto-merge September 8, 2025 05:27
@gregpr07 gregpr07 merged commit e41b156 into main Sep 8, 2025
53 checks passed
@gregpr07 gregpr07 deleted the feature/paint-order-filtering branch September 8, 2025 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Interaction Issue: Element highlighting incorrectly includes iframe content when modal is open
1 participant
@gregpr07