make reasoning_models a parameter #3010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the condition for checking reasoning_models to ensure it only evaluates if reasoning_models is not empty, improving code robustness.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Changed the initialization of reasoning_models to use a default factory with field(), enhancing clarity and maintainability of the code.
Agent Task Evaluation Results: 2/4 (50%)View detailed results
Check the evaluate-tasks job for detailed task execution logs. |
qizwiz
added a commit
to qizwiz/browser-use
that referenced
this pull request
Sep 16, 2025
- Replace hardcoded ReasoningModels import with configurable self.reasoning_models - Add fallback to default reasoning models list for backward compatibility - Align with MagMueller's PR browser-use#3010 that makes reasoning_models configurable This change ensures compatibility with the latest changes in the codebase while maintaining the same Azure-specific parameter filtering functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto-generated PR for: make reasoning_models a parameter
Summary by cubic
Made reasoning_models configurable on ChatOpenAI so users can control which models are treated as “reasoning” models. Defaults to the previous list, so behavior is unchanged unless overridden.