chore: standardize import order readme #3062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
There was a problem hiding this comment.
1 issue found across 1 file
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Ask questions if you need clarification on any suggestion
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
| load_dotenv() | ||
| from browser_use import Agent, ChatOpenAI | ||
|
|
||
| load_dotenv() |
There was a problem hiding this comment.
This change moves load_dotenv() to after the browser_use import, but the browser_use package reads environment variables upon initialization (in browser_use/__init__.py). This will cause the example code to behave unexpectedly as environment variables from a .env file won't be loaded at the time of import.
Prompt for AI agents
Address the following comment on README.md at line 74:
<comment>This change moves `load_dotenv()` to after the `browser_use` import, but the `browser_use` package reads environment variables upon initialization (in `browser_use/__init__.py`). This will cause the example code to behave unexpectedly as environment variables from a `.env` file won't be loaded at the time of import.</comment>
<file context>
@@ -69,9 +69,10 @@ Spin up your agent:
-load_dotenv()
from browser_use import Agent, ChatOpenAI
+load_dotenv()
+
async def main():
</file context>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardize import order in README Python example for clarity and best practices. 🙏
Summary by cubic
Standardized the README Python example by grouping imports and moving load_dotenv() below them for clarity and consistency.