fix: restore token count display in verbose debug logs#4151
Open
ManthanNimodiya wants to merge 3 commits intobrowser-use:mainfrom
Open
fix: restore token count display in verbose debug logs#4151ManthanNimodiya wants to merge 3 commits intobrowser-use:mainfrom
ManthanNimodiya wants to merge 3 commits intobrowser-use:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_log_history_lines()was entirely commented out and returned'', so no message history was ever logged in debug mode_log_format_message_line()referencedmessage.metadata.tokensbutBaseMessagehas nometadataattribute — the old wrapper-object data model it relied on no longer exists_log_extract_message_content()which was removed in a prior refactorRestores both functions using the current
BaseMessageAPI (.textproperty +MessageHistory.get_messages()). Token counts are estimated via the standard ~4 chars/token heuristic; the~prefix makes the approximation explicit. Actual billed token counts remain tracked by theTokenCostservice post-response as before.Fixes #4150
Changes
service.py: add missingimport shutil(was referenced in commented-out code but never imported)_log_format_message_line: replace'??? (TODO)'withf'~{len(content) // 4}'.rjust(5)_log_history_lines: fully restored usingget_messages()/m.text; dead references to oldm.metadata/m.message/_log_extract_message_contentremovedTesting
Enable
logging.DEBUGand run any agent task. Verbose logs now show:Summary by cubic
Restores verbose message history logging and shows approximate token counts (~4 chars/token) in debug output. Fixes #4150.
Written for commit 4dcf983. Summary will update on new commits.