Open
Conversation
Agent Task Evaluation Results: 2/2 (100%)View detailed results
Check the evaluate-tasks job for detailed task execution logs. |
Contributor
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="browser_use/dom/service.py">
<violation number="1" location="browser_use/dom/service.py:867">
P2: The `session` variable is retrieved inside `_construct_enhanced_node`, which runs for every DOM node. This causes substantial overhead (N awaits for N nodes) and is inefficient, especially with the added CDP calls in this PR. Move the session retrieval to `get_dom_tree` (outside the recursive function) and capture it in the closure.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| ) | ||
| elif session_id is not None: | ||
| try: | ||
| resolved_iframe = await session.cdp_client.send.DOM.describeNode( |
Contributor
There was a problem hiding this comment.
P2: The session variable is retrieved inside _construct_enhanced_node, which runs for every DOM node. This causes substantial overhead (N awaits for N nodes) and is inefficient, especially with the added CDP calls in this PR. Move the session retrieval to get_dom_tree (outside the recursive function) and capture it in the closure.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At browser_use/dom/service.py, line 867:
<comment>The `session` variable is retrieved inside `_construct_enhanced_node`, which runs for every DOM node. This causes substantial overhead (N awaits for N nodes) and is inefficient, especially with the added CDP calls in this PR. Move the session retrieval to `get_dom_tree` (outside the recursive function) and capture it in the closure.</comment>
<file context>
@@ -841,16 +842,62 @@ async def _construct_enhanced_node(
+ )
+ elif session_id is not None:
+ try:
+ resolved_iframe = await session.cdp_client.send.DOM.describeNode(
+ params={'backendNodeId': node['backendNodeId'], 'pierce': True, 'depth': 1},
+ session_id=session_id,
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Prevent CDP iframe recursion in DOM snapshots by disabling pierce and resolving same-origin iframe content with bounded traversal. Addresses #2715; avoids CBOR stack overflow and stabilizes snapshot generation; minor lint.
Written for commit 18bd91d. Summary will update on new commits.