[feature]: Add SSE support #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexdphan
reviewed
May 6, 2025
| @@ -0,0 +1 @@ | |||
| import './dist/program.js'; | |||
There was a problem hiding this comment.
should cli.js this be a .ts file
browserbase/package-lock.json
Outdated
There was a problem hiding this comment.
why remove it? i guess it doesn't really matter whether or not we have but its in the current implementation
| { | ||
| "mcpServers": { | ||
| "playwright": { | ||
| "url": "http://localhost:8931/sse", |
There was a problem hiding this comment.
will there a be a place for flags?
cli commands?
There was a problem hiding this comment.
probably can link to config.d.ts
There was a problem hiding this comment.
yeah ill add more info, flags would be in the args
| @@ -0,0 +1,2 @@ | |||
| import { createServer } from './dist/index.js'; | |||
There was a problem hiding this comment.
its js so you can run with node technically i think it can be as long as cli.js is js since thats our entrypoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Added ability to connect with server side events.