window.sessionStorage throws an exception when cookies are disabled in some browsers #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uding output of buildr
|
I just realized my fix is practically identical to startswithaj's (should have checked the pull requests first- d'oh), except that I ran buildr afterwards and updated the compressed and uncompressed bundles. |
ghost
pushed a commit
that referenced
this pull request
Dec 4, 2013
window.sessionStorage throws an exception when cookies are disabled in some browsers
|
Thank you! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: Accessing window.sessionStorage throws an exception in some browsers (including Chrome) when cookies/localStorage are explicitly disabled. This causes history.js to completely die because one of the very first things it does is to check sessionStorage availability outside of a try/catch.
To reproduce: