Thanks to visit codestin.com
Credit goes to github.com

Skip to content

psbt: add new fields for MuSig2#2198

Open
guggero wants to merge 6 commits into
btcsuite:masterfrom
guggero:bip-musig2-psbt
Open

psbt: add new fields for MuSig2#2198
guggero wants to merge 6 commits into
btcsuite:masterfrom
guggero:bip-musig2-psbt

Conversation

@guggero
Copy link
Copy Markdown
Collaborator

@guggero guggero commented Jun 14, 2024 •
edited
Loading

Implements the new input and output fields to the PSBT library according to BIP-0373.

@guggero guggero mentioned this pull request Jun 14, 2024
Merged
@coveralls
Copy link
Copy Markdown

coveralls commented Jun 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9513655947

Details

  • 4 of 240 (1.67%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 56.774%
Changes Missing Coverage Covered Lines Changed/Added Lines %
btcutil/psbt/partial_output.go 1 22 4.55%
btcutil/psbt/partial_input.go 3 63 4.76%
btcutil/psbt/musig2.go 0 155 0.0%
Files with Coverage Reduction New Missed Lines %
connmgr/connmanager.go 3 86.27%
Totals Coverage Status
Change from base Build 9348961734: -0.2%
Covered Lines: 29625
Relevant Lines: 52181
💛 - Coveralls

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9519109524

Details

  • 4 of 381 (1.05%) changed or added relevant lines in 5 files are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.4%) to 56.6%
Changes Missing Coverage Covered Lines Changed/Added Lines %
btcutil/psbt/partial_output.go 1 22 4.55%
btcutil/psbt/utils.go 0 22 0.0%
btcutil/psbt/partial_input.go 3 63 4.76%
btcutil/psbt/finalizer.go 0 119 0.0%
btcutil/psbt/musig2.go 0 155 0.0%
Files with Coverage Reduction New Missed Lines %
connmgr/connmanager.go 3 86.27%
txscript/taproot.go 5 95.31%
Totals Coverage Status
Change from base Build 9348961734: -0.4%
Covered Lines: 29614
Relevant Lines: 52322
💛 - Coveralls

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 15, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9528732501

Details

  • 4 of 381 (1.05%) changed or added relevant lines in 5 files are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.4%) to 56.603%
Changes Missing Coverage Covered Lines Changed/Added Lines %
btcutil/psbt/partial_output.go 1 22 4.55%
btcutil/psbt/utils.go 0 22 0.0%
btcutil/psbt/partial_input.go 3 63 4.76%
btcutil/psbt/finalizer.go 0 119 0.0%
btcutil/psbt/musig2.go 0 155 0.0%
Files with Coverage Reduction New Missed Lines %
connmgr/connmanager.go 2 87.32%
peer/peer.go 9 73.72%
Totals Coverage Status
Change from base Build 9348961734: -0.4%
Covered Lines: 29616
Relevant Lines: 52322
💛 - Coveralls

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 15, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9528834149

Details

  • 4 of 381 (1.05%) changed or added relevant lines in 5 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.4%) to 56.626%
Changes Missing Coverage Covered Lines Changed/Added Lines %
btcutil/psbt/partial_output.go 1 22 4.55%
btcutil/psbt/utils.go 0 22 0.0%
btcutil/psbt/partial_input.go 3 63 4.76%
btcutil/psbt/finalizer.go 0 119 0.0%
btcutil/psbt/musig2.go 0 155 0.0%
Files with Coverage Reduction New Missed Lines %
connmgr/connmanager.go 3 86.97%
Totals Coverage Status
Change from base Build 9348961734: -0.4%
Covered Lines: 29628
Relevant Lines: 52322
💛 - Coveralls

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 15, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9528865705

Details

  • 4 of 387 (1.03%) changed or added relevant lines in 5 files are covered.
  • 12 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.4%) to 56.607%
Changes Missing Coverage Covered Lines Changed/Added Lines %
btcutil/psbt/partial_output.go 1 22 4.55%
btcutil/psbt/utils.go 0 22 0.0%
btcutil/psbt/partial_input.go 3 63 4.76%
btcutil/psbt/finalizer.go 0 125 0.0%
btcutil/psbt/musig2.go 0 155 0.0%
Files with Coverage Reduction New Missed Lines %
connmgr/connmanager.go 3 86.27%
peer/peer.go 9 73.72%
Totals Coverage Status
Change from base Build 9348961734: -0.4%
Covered Lines: 29621
Relevant Lines: 52327
💛 - Coveralls

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 15, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9528900206

Details

  • 6 of 389 (1.54%) changed or added relevant lines in 5 files are covered.
  • 12 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.4%) to 56.587%
Changes Missing Coverage Covered Lines Changed/Added Lines %
btcutil/psbt/partial_output.go 1 22 4.55%
btcutil/psbt/utils.go 0 22 0.0%
btcutil/psbt/partial_input.go 3 63 4.76%
btcutil/psbt/finalizer.go 2 127 1.57%
btcutil/psbt/musig2.go 0 155 0.0%
Files with Coverage Reduction New Missed Lines %
connmgr/connmanager.go 3 86.27%
peer/peer.go 9 73.49%
Totals Coverage Status
Change from base Build 9348961734: -0.4%
Covered Lines: 29611
Relevant Lines: 52328
💛 - Coveralls

@guggero guggero mentioned this pull request Jun 15, 2024
Closed
@coveralls
Copy link
Copy Markdown

coveralls commented Jan 19, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 14964403415

Details

  • 6 of 389 (1.54%) changed or added relevant lines in 5 files are covered.
  • 30 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-1.6%) to 55.082%
Changes Missing Coverage Covered Lines Changed/Added Lines %
btcutil/psbt/partial_output.go 1 22 4.55%
btcutil/psbt/utils.go 0 22 0.0%
btcutil/psbt/partial_input.go 3 63 4.76%
btcutil/psbt/finalizer.go 2 127 1.57%
btcutil/psbt/musig2.go 0 155 0.0%
Files with Coverage Reduction New Missed Lines %
btcutil/gcs/gcs.go 1 80.95%
mempool/mempool.go 1 66.56%
rpcclient/infrastructure.go 3 47.75%
btcec/v2/schnorr/signature.go 5 79.92%
btcec/v2/ecdsa/signature.go 20 69.7%
Totals Coverage Status
Change from base Build 14871723979: -1.6%
Covered Lines: 31088
Relevant Lines: 56440
💛 - Coveralls

@guggero guggero force-pushed the bip-musig2-psbt branch from 8e879e1 to 35a2775 Compare May 12, 2025 05:18
@guggero guggero force-pushed the bip-musig2-psbt branch from 35a2775 to e4bb95c Compare May 20, 2026 12:33
@guggero guggero force-pushed the bip-musig2-psbt branch from e4bb95c to 04ec8d7 Compare May 20, 2026 13:03
@guggero
Copy link
Copy Markdown
Collaborator Author

guggero commented May 20, 2026

The BIP-0373 PR was merged a while ago. I also rebased on latest master that has the Golang module fixes and addressed all TODOs. This is ready for review IMO.

@guggero guggero marked this pull request as ready for review May 20, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@guggero @coveralls