multi: pin new v2 submodule tags and bump to v0.26.0-beta.rc1#2532
Merged
Conversation
In this commit, we strip all of the local `replace ... => ../...` directives that were introduced as part of btcsuite#1825 (the v2 module restructuring), now that proper tags exist for every freshly carved-out submodule. Every in-tree go.mod is pinned to the newly published tags: chainhash/v2.0.0, wire/v2.0.0, chaincfg/v2.0.0, address/v2.0.0, txscript/v2.0.0, btcutil/v2.0.0, psbt/v2.0.0, and btcec is bumped to v2.5.0 since it now depends on chainhash/v2 (previously chaincfg/chainhash). While here, we also unify the Go toolchain to 1.25 across every submodule so the workspace resolves a consistent set of language features. Finally, we bump the main btcd version to v0.26.0-beta.rc1 in preparation for the upcoming release candidate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, we follow up on #1825 by stripping the temporary
replace ... => ../...directives that were used to make the freshly carved-out v2 submodules build locally while their tags didn't yet exist. Tags now exist for every submodule (pushed at the merge commit of #1825), so each in-treego.modis pinned directly to the published version, and downstream consumers can pull the v2 modules through the normal proxy path.Tags consumed
The wave of tags pushed alongside this PR:
btcecis bumped fromv2.4.0tov2.5.0since it now depends onchainhash/v2(it used to pullchaincfg/chainhash), so its require set changed even though the public API surface didn't.Toolchain + version bump
While we're touching every
go.mod, we unify the Go toolchain to1.25across the board. A few of the new submodules from #1825 (chainhash, wire, chaincfg) landed on1.23.2since that was the floor at the time the PR was originally written. Now they match everything else, so the workspace resolves a consistent set of language features.We also bump
version.gofromv0.25.0-betatov0.26.0-beta.rc1in preparation for the next release candidate.Test plan
go build ./...clean in every module (chainhash, btcec, wire, chaincfg, address, txscript, btcutil, psbt, v2transport, root)go test ./...clean in every modulego vet ./...clean across every module