Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove pipenv install from Makefile #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 7, 2025
Merged

Remove pipenv install from Makefile #299

merged 12 commits into from
May 7, 2025

Conversation

smaye81
Copy link
Member

@smaye81 smaye81 commented May 6, 2025

This removes the install of pipenv from the Makefile. Instead, mandating that users should install it on their own system-wide.

In addition , it fixes the pyproject.toml to use the new metadata for license-expression and license-file.

@smaye81 smaye81 requested review from Alfus and jchadwick-buf May 6, 2025 21:34
@smaye81 smaye81 changed the title Override matches function with re2 implementation Remove pipenv install from Makefile May 7, 2025
@smaye81 smaye81 requested a review from Alfus May 7, 2025 15:22
@smaye81
Copy link
Member Author

smaye81 commented May 7, 2025

We decided to remove re2 for now because there are no built wheels for Python 3.13 for some reason (issue). Will reassess in the future.

@smaye81 smaye81 merged commit 1d4f02e into main May 7, 2025
15 checks passed
@smaye81 smaye81 deleted the sayers/re2 branch May 7, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants