update config.php to utilize environment variables#71
Merged
Conversation
assets are typically overwritten every time the package is updated, so users should have an alternative way to set their bugsnag configuration that prevents having to redo it on updates. this update allows users to set configuration with their environment variables, but falls back on the sensible defaults. this change is non-breaking. also use short array syntax
Contributor
Author
|
thoughts? |
Contributor
Author
|
could an owner please comment, merge, or close please? |
Contributor
Author
|
correct, but when you publish assets, this file is copied to |
Contributor
|
Thank you for the contribution, @browner12. This change makes sense, particularly since you can already load the API key from an environment variable. I'll add a few lines to the configuration documentation for the change and then it is ready to ship. |
kattrali
added a commit
that referenced
this pull request
Dec 7, 2015
update `config.php` to utilize environment variables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
assets are typically overwritten every time the package is updated, so users should have an alternative way to set their bugsnag configuration that prevents having to redo it on updates. this update allows users to set configuration with their environment variables, but falls back on the sensible defaults. this change is non-breaking.
also use short array syntax