Let Laravel decide whether to report or not#97
Conversation
|
Also just saw that this change was proposed in #69, although in that case it was purely to remove repetitive code. I agree with that entirely, but the main point in this PR is to stop |
|
This looks good, @philbates35. Thank you for the contribution. Merging. |
Let Laravel decide whether to report or not Closes #69
|
glad it got merged. thanks! |
|
@kattrali Any chance we can get a new tagged release containing this fix? It's been a while, and my Bugsnag is littered with |
|
@GrahamCampbell I've seen you've been working on this library in the last couple of days. Are you planning on tagging a new release soon? The |
|
I'll add a branch alias here for you so you don't have to use dev-master. I'll look into getting a release soon too for you. :) |
|
You should be able to get the current version using the constraint |
In Laravel 5.2,
Illuminate\Foundation\Exceptions\Handler::shouldntReport()was modified to never reportIlluminate\Http\Exception\HttpResponseExceptionexceptions. This updated logic was never captured in theBugsnagExceptionHandler, so in a Laravel 5.2 application, allHttpResponseExceptions are reported by default when they shouldn't be.It makes sense to just use
$this->shouldReport($e)to determine if the exception should be reported - that way no logic is duplicated, and ifshouldReport()is modified again in the future, there will be no need to update this package.The
shouldReport()method has been present since 5.0 so this change is compatible with 5.0-5.2.