[5.2] Bug 1837680: Add Message-ID header when missing at send #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detect whether a Message-ID header has been included in the message passed to MessageToMTA and generate one if it's missing. GMail and other modern mail services now expect a Message-ID as part of the message else they mark them as spam or drop them entirely.
Contributor
Author
|
I would have liked to make the new build_message_id sub a little more generic and use it for both build_thread_marker and MessageToMTA, but I felt we could do that at a later stage. I'm also not entirely sure about the user-id inclusion here.. I'm not close enough to the codebase with regards to how Bugzilla->user works yet to know whether it will get the right user in this case.. I also wasn't sure how I could get back to the userid within MessateToMTA.. I wondered about trying to extract the 'To' address and perform a lookup of users on that? Anyway, here's a first draft for review. Unit tests also to follow once I've had some initial feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Detect whether a Message-ID header has been included in the message passed to MessageToMTA and generate one if it's missing.
GMail and other modern mail services now expect a Message-ID as part of the message else they mark them as spam or drop them entirely.
Additional info