distutils scripts -- correct order of operations #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… lines are correctly recognized.
|
Thanks for the PR! Someone will need to write a test before this can be merged. |
|
The fix (for my original mistake :-) ) looks good. I've pulled the branch into my clone so that travis can check it. I'm seeing the same problem with docutils' scripts, so the fix is very welcome. |
jimfulton
pushed a commit
that referenced
this pull request
Jul 12, 2013
distutils scripts -- correct order of operations
tseaver
added a commit
that referenced
this pull request
Sep 5, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So 'from ... import' lines are correctly recognized. The following example from pylint was not being correctly parsed: