feat: sync mssql triggers #16059
Merged
feat: sync mssql triggers #16059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: h3n4l <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR adds trigger synchronization to the MSSQL schema sync functionality.
- Added a new function (getTriggers) to retrieve trigger metadata from the database.
- Updated the SyncDBSchema method to integrate trigger data with table and view metadata.
- Removed a redundant comment from the getProcedures function.
Comments suppressed due to low confidence (1)
backend/plugin/db/mssql/sync.go:841
- [nitpick] The variable 'm' used for selecting the triggers map based on parent type could be renamed to something more descriptive (e.g., 'targetTriggers') to improve readability.
m := tableTriggers
RainbowDashy
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.